Open
Conversation
Owner
|
Hi Derkan, It's a breaking change. I can't do this without publishing a "v2". I've another problem : no time to maintain this seriously. I will test on newer Go versions and update the test matrix and README, but nothing more, at least in short time. It took me almost 3 weeks to reply, it's not very serious as a maintainer, I'm sorry. The project is stable, it's usable as-is. Next major evolution could involve generics. Also I think code generation is also better then reflection. If something will evolve, it will rather be a revolution. If you fork durably the project I could mention it in the README. I will not be very available next weeks, but I'll do it, at worse in September. Samuel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Samuel, I hope you are doing well. I removed db driver dependencies in this PR.
PR provides using
pgx/stdlibdriver instead ofpg(ormodernc.org/sqliteinstead ofmattn/go-sqlite3...). Also this makes exe size smaller when user uses alternate drivers.Only drawback: user should import his/her driver before using it(not auto imported when imported relevant
adapter. And I think mostly users do this beforehand.